SQLiteAdapter::select_rows misses columns when column names are ambiguous

When select_rows is used on a SQLite database and the selected columns include some with the same name in different tables, the last of the columns selected (not necessarily the ambiguous ones) will not appear in the result rows. The bug can be worked around by giving unambiguous aliases to the columns selected. I was using ruby 1.8.7 and rails 2.3.5.

An example follows.

config/schema.rb

ActiveRecord::Schema.define(:version => 20100503193703) do
  create_table "dogs", :force => true do |t|
    t.string   "name"
    t.string   "color"
    t.integer  "owner_id"
    t.datetime "created_at"
    t.datetime "updated_at"
  end

  create_table "people", :force => true do |t|
    t.string   "name"
    t.datetime "created_at"
    t.datetime "updated_at"
  end
end

app/models/dog.rb

class Dog < ActiveRecord::Base
  belongs_to :person
end

app/models/person.rb

class Person < ActiveRecord::Base
  has_many :dog
end

db/seeds.rb

bob = Person.create(:name => 'Bob')
Dog.create(:name => 'Fido', :owner_id => bob.id, :color => 'brown')

app/controllers/home_controller.rb

require 'pp'
class HomeController < ApplicationController
  def index
    @dog_show = ActiveRecord::Base::connection.select_rows 'SELECT people.name, dogs.name, dogs.color FROM people INNER JOIN dogs ON dogs.owner_id = people.id'
    pp @dog_show #=> [["Bob", "Fido"]]

    @dog_show = ActiveRecord::Base::connection.select_rows 'SELECT people.name, dogs.name as dogname, dogs.color FROM people INNER JOIN dogs ON dogs.owner_id = people.id'
    pp @dog_show #=> [["Bob", "Fido", "brown"]]
  end
end

The bug appears to be due to the implementation of select_rows in activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb

def select_rows(sql, name = nil)
  execute(sql, name).map do |row|
    (0...(row.size / 2)).map { |i| row[i] }
  end
end

With the ambiguous column names in the example, the value returned by execute is:

[{"name"=>"Fido", 0=>"Bob", 1=>"Fido", 2=>"brown", "color"=>"brown"}]

Due to the ambiguity, there is no "name"=>"Bob" pair, so the number of columns is not row.size/2 as is assumed.

The following monkey patch seemed to fix the problem, but I have not tested it properly and it seems that the code could be more "rubyish".

module ActiveRecord
  module ConnectionAdapters
    class SQLiteAdapter
        def select_rows(sql, name = nil)
          rows = execute(sql, name)
          pp rows
          rows.map do |row|
            (0...(row.size / 2)).map { |i| row[i] }
          end
        end
    end
  end
end

I have not tested the bug with other databases, but their code for select_rows looks totally different.