This project is archived and is in readonly mode.
Erubis template parsing error on invalid match for variable name containing "do"
-
Ryan Bigg- Tag changed from 3.0.0.beta3, erubis to 3.0.0.beta3, bugmash, erubis
- State changed from new to incomplete
Please provide a failing test case and patch for this issue.
-
Jeff KreeftmeijerVerified on master. When I generate a scaffold called todo, start the server and go to /todos, it throws a SyntaxError:
compile error /Users/jeff/rails/tada/app/views/todos/index.html.erb:16: syntax error, unexpected tIVAR, expecting kDO or '{' or '(' ...to 'Show', todo @output_buffer.safe_concat('</td> ^Here's the Framework Trace.
-
Simon JeffordI've attached a patch
It doesn't have any tests at the moment - hoping to enlist some help on that front...
-
Simon Jefford
Patch with test
-
Santiago Pastorino
- Milestone cleared.
- Tag changed from 3.0.0.beta3, bugmash, erubis to 3.0.0.beta3, bugmash, bugmash-review, erubis, patch
- State changed from incomplete to open
- Assigned user set to José Valim
Well done Simon +1
-
Eric Hutzelman+1 applies cleanly to master, tests pass. Scaffold generated Todo views no longer throw errors on 'show' links.
-
Repository
- State changed from open to resolved
(from [f58bdae1f716c71202546c5a40a951b5fc54a591]) Check blocks are not incorrectly detected when compiling erubis templates [#4575 Erubis template parsing error on invalid match for variable name containing "do" state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f58bdae1f716c71202546c5a40a951... -
Rizwan Reza- Tag changed from 3.0.0.beta3, bugmash, bugmash-review, erubis, patch to 3.0.0.beta3, bugmash, erubis, patch
-
Rizwan Reza
- Tag changed from 3.0.0.beta3, bugmash, erubis, patch to 3.0.0.beta3, bugmash-review, erubis, patch
- State changed from resolved to verified
-
Rizwan Reza
- State changed from verified to resolved
-
Rizwan Reza
- Tag changed from 3.0.0.beta3, bugmash-review, erubis, patch to 3.0.0.beta3, erubis, patch
-
-
