This project is archived and is in readonly mode.

#4588 ✓stale
Lawrence Pit

Cache increment/decrement with initialization when missing value

Reported by Lawrence Pit | May 13th, 2010 @ 02:24 AM

This patch makes incrementing/decrementing values using Rails.cache easier, particularly if one uses memcache. For proper use of incr/decr using memcache see http://code.google.com/p/memcached/wiki/NewProgramming#Proper_Use_o...

This patch allows passing in a block to the +increment+ and +decrement+ methods of Rails.cache, similarly to how +Rails.cache.fetch+ works.

Note that the implementation for mem_cache_store takes some pain away by storing the initial value raw and using +add+ instead of +set+, and retries an increment/decrement in case +add+ returns +false+.

This patch also adds a missing test to the increment/decrement behavior test, namely the one that tests for +nil+, and has modified mem_cache_store so that it's behavior is consistent with the other cache stores.

Comments and changes to this ticket

  • Lawrence Pit

    Lawrence Pit June 8th, 2010 @ 05:19 AM

    • Tag set to patch
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Referenced by

Pages