Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActionPack tests have errors and failures

#4613

ActionPack in Rails master has 3 errors and 2 failures in the test suite. Ran on ruby 1.9.2dev (2010-05-08 trunk 27665) [x86_64-linux]

I have fixed 3 errors and 1 failure and will submit a patch after I get a ticket nos. The remaining failure(nos 5 in the trace) has something to do with #4559 sending :id => nil to form helpers does not remove the "id" html attribute I believe, #4559 sending :id => nil to form helpers does not remove the "id" html attribute (Thanks to wijnand_ from #railsbridge for pointing out that ticket).

Stack trace (or pastie => http://pastie.org/962333 ):
P.S I have removed the dots here since it occupies a lot of space)

1) Failure: test_assert_select_text_match(AssertSelectTest) [test/controller/assert_select_test.rb:210]:
Exception raised:
<#<ArgumentError: assertion message must be String or Proc, but Hash was given.>>.

2) Error: test_css_select(AssertSelectTest):
ArgumentError: assertion message must be String or Proc, but Fixnum was given.

test/controller/assert_select_test.rb:279:in `test_css_select'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'

3) Error: test_with_output_buffer_sets_proper_encoding(CaptureHelperTest):
ArgumentError: assertion message must be String or Proc, but Encoding was given.

test/template/capture_helper_test.rb:77:in `block in test_with_output_buffer_sets_proper_encoding'
/home/rohit/remote-repos/rails/actionpack/lib/action_view/helpers/capture_helper.rb:150:in `with_output_buffer'
test/template/capture_helper_test.rb:76:in `test_with_output_buffer_sets_proper_encoding'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'

4) Error: test_render_against_etag_request_should_have_no_content_length_when_match(EtagRenderTest):
ArgumentError: assertion message must be String or Proc, but NilClass was given.

test/controller/render_test.rb:1391:in `test_render_against_etag_request_should_have_no_content_length_when_match'
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:35:in `block in run'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/callbacks.rb:428:in `_run_setup_callbacks'
/home/rohit/remote-repos/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:34:in `run'

5) Failure: test_nil_id(FormHelperTest) [test/template/form_helper_test.rb:452]:
<" expected to be == to
<"..
Expected block to return true value.

2678 tests, 11309 assertions, 2 failures, 3 errors, 0 skips

Reported by Rohit Arondekar · May 16th, 2010 @ 08:33 AM

State: resolved
Milestone: none
Assigned to: José Valim José Valim
Importance: none

Activity

  1. Rohit Arondekar
  2. Rohit Arondekar
    Rohit Arondekar
    • Tag set to actionpack rails3, tests actionpack, bugmash-patch

    May 16th, 2010 @ 08:40 AM

  3. Rohit Arondekar
    Rohit Arondekar
    • Tag changed from actionpack rails3, tests actionpack, bugmash-patch to actionpack rails3, tests actionpack, bugmash

    Sorry for the bad tagging. :(

    May 16th, 2010 @ 08:41 AM

  4. Rizwan Reza
    Rizwan Reza
    • State changed from new to open

    We need some +1s here.

    May 16th, 2010 @ 09:29 AM

  5. Hussein Morsy
    Hussein Morsy

    Rohit has fixed 1 failure und 3 Errors. A fix for one failure is still missing.
    I have patch which includes 2 commits (one from Rohit and one from me):

    all test in ActionPack are working in ruby 1.8.7 and ruby 1.9.2

    May 16th, 2010 @ 01:16 PM

  6. Repository
  7. Hussein Morsy
    Hussein Morsy

    here is my isolated patch of my fix of 1 failure

    May 16th, 2010 @ 01:53 PM

  8. Repository
  9. Rizwan Reza
    Rizwan Reza
    • Tag changed from actionpack rails3, tests actionpack, bugmash to actionpack rails3, tests actionpack

    May 16th, 2010 @ 03:04 PM