Valid number pretending to be a invalid number in ActiveModel tests

I've attached a patch.

P.S rubydiamond from #railsbridge has confirmed that the tests pass in 1.8.7, so it might be something that needs to be looked into more carefully.

+1

Verified patch on ruby-1.8.7-p249 and ruby-1.9.2-head.

Still a question I have is, why 1.9.2 considers 0xdeadbeef as valid number but 1.8.7 does not.

When inspected in irb for both rubies, it shows

ruby-1.8.7-p249 >   0xdeadbeef.class
 => Bignum 
ruby-1.8.7-p249 > 0xdeadbeef
 => 3735928559

ruby-1.9.2-head > 0xdeadbeef.class
 => Bignum 
ruby-1.9.2-head > 0xdeadbeef
 => 3735928559

Need to know reason for putting this hex number 0xdeadbeef as not valid numerical test. Thoughts?

Looks like 1.9.2 is converting hex number to float but 1.8.7 don't

ruby-1.8.7-p249 > Kernel.Float("0xdeadbeef")
ArgumentError: invalid value for Float(): "0xdeadbeef"
    from (irb):1:in `Float'
    from (irb):1

ruby-1.9.2-head > Kernel.Float("0xdeadbeef")
 => 3735928559.0

+1 for the patch

I think I've got it! Take a look at the following code from activemodel/lib/active_model/validations/numericality.rb

  def parse_raw_value_as_a_number(raw_value)
    begin
      Kernel.Float(raw_value)
    rescue ArgumentError, TypeError
      nil
    end
  end

  def parse_raw_value_as_an_integer(raw_value)
    raw_value.to_i if raw_value.to_s =~ /\A[+-]?\d+\Z/
  end

Note how a raw integer value is parsed. Using a regex, most probably because Kernel.Integer honors radix indicators like 0x.

Whereas a raw float is parsed using Kernel.Float which until 1.9.2 (or maybe 1.9.1) didn't honor radix indicators. But now that it does on 1.9.2, bam! it accepts a number which was not meant to be accepted. That's my understanding so far about this issue.

I can confirm that ruby 1.9.1p378 (2010-01-10 revision 26273) [x86_64-linux] behaves like 1.8.7 but 1.9.2 doesn't. I believe I've found the changeset that did this => http://redmine.ruby-lang.org/repositories/revision/ruby-19?rev=26965 and it's associated feature => http://redmine.ruby-lang.org/issues/show/2969 but the discussions are in Japanese :(

I can't make any more progress on this issue as I think I've reached a dead-end, I don't plan on digging in the Ruby source code :P. Hopefully a Core member or somebody who knows how the validator should behave can shed some light.

I've attached a patch which fixes the broken numericality tests for ruby-1.9.2-head. Tests pass on ruby-1.8.7-p249 too.

(from [05e3fb45eeacd20f2b8b5691f17d6fdf2fb4582b]) Add a valid hex that shouldn't be valid to ActiveModel numericality tests [#4622 Valid number pretending to be a invalid number in ActiveModel tests state:commited]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/05e3fb45eeacd20f2b8b5691f17d6f...

(from [8e3c3b06dc8ff8842f6390efc58eaf4bb1a23060]) Fixed numericality validator in ActiveModel to reject hex numbers for floats completely [#4622 Valid number pretending to be a invalid number in ActiveModel tests state:commited]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/8e3c3b06dc8ff8842f6390efc58eaf...

Automatic cleanup of spam.

Instructions: download and untar to /sites/all/modules

also - Download and install 'Rules' module to /sites/all/modules

Run /update.php

Goto Admin>Build>Modules, enable "OA Single Group Login Redirect" module and allow Rules module to be activated when prompted.

Log-out as admin and log-in as user with 1 group - page redirects as expected.

Greyside Thank-you!

Thank you for this information,I like it very much,Would you lik a pair of
Pachuco Suits
pack linen clothes
pack suit into suit
pant length
pant length for men

paul smith mens suits
Welcome to our store,We have the best service team!