This project is archived and is in readonly mode.
expected value should come first in assert_equal
Reported by Neeraj Singh | May 17th, 2010 @ 09:34 PM
In the following test expected value should come first and the value being tested later.
def test_pooled_connection_checkout
checkout_connections
assert_equal @connections.length, 2
assert_equal @timed_out, 2
end
patch will be provided through comment.
Comments and changes to this ticket
-
Neeraj Singh May 17th, 2010 @ 09:51 PM
- Tag changed from “activerecord, rails3” to “activerecord, patch, rails3”
Attached is patch against rails edge.
-
Jeff Kreeftmeijer May 17th, 2010 @ 10:51 PM
+1
Applies cleanly to master. And yes, the expected value should come first. :)
-
Repository May 18th, 2010 @ 03:13 PM
- State changed from “new” to “resolved”
(from [0ef13afef53bb53f709be7adab3e863ec62eae62]) expected value should come first in assert_equal
[#4630 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/0ef13afef53bb53f709be7adab3e86...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Neeraj Singh
Attachments
Tags
Referenced by
-
4630
expected value should come first in assert_equal
[#4630 state:resolved]