This project is archived and is in readonly mode.
backport test fixs related to SQLite from master
-
Aaron Patterson
Here is my take on the backport.
-
Xavier Noria
- State changed from new to resolved
Applied in http://github.com/rails/rails/commit/a637b5f4471be6b7284673fc719630...
Thanks!
-
Santiago Pastorino
Here i'm sending a part of the backport that is important because is safer.
And a tiny refactor for master, so the code on master and 2-3-stable follows the same logic. -
Aaron Patterson
+1 on both of these patches from me. They will make sure rails 2.3.x works with future versions of sqlite-ruby
-
Xavier Noria
Regarding the 2.3 patch, I see a similar string comparison on line 236:
index.unique = row['unique'] != '0'Should that one get a #to_i call as well?
Another question: these field and row values can't be nil right? You know, nil.to_i would give 0 and thus the test would pass, while now we have nil == "0", which would not.
-
Santiago Pastorino
my patch changes the line 236
-
Repository
(from [240f4e944cd90fca138aba8467456043952110cc]) SQLite: forward compatibility with future driver releases
[#4633 backport test fixs related to SQLite from master]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/240f4e944cd90fca138aba84674560... -
Repository
(from [47d568ed3fc701934ebe80b276f3d8bf6951c93f]) Refactor calculation test to remove unneeded SQLite special case.
[#4633 backport test fixs related to SQLite from master]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/47d568ed3fc701934ebe80b276f3d8...
