This project is archived and is in readonly mode.
Full class name STI not included in eager loading
-
Joachim Garth
- Tag set to 2.1, activerecord, bug, eager_loading, patch, tested
Confirmed; "Wrote a patch" for it... could anybody confirm this?
-
Pratik
- State changed from new to incomplete
- Tag changed from 2.1, activerecord, bug, eager_loading, patch, tested to 2.1, activerecord, bug, eager_loading, patch
Could you please generate the patch using git-format-patch ? Also, the patch is missing tests.
Thanks.
-
Joachim Garth
Done and done. :) It's a git format-patch now. Tests are included now, as well.
-
Pratik
- State changed from incomplete to open
-
Christian Weyer
This bug seems to be bigger than I first thought. When checking http://rails.lighthouseapp.com/a... I could not find any code changes for eager loading at all?
I still encounter this bug after applying Josch's patch in other scenarios, not related to polymorphic associations. How comes nobody noticed that? Am I the only one using namespaces?
-
Christian Weyer
- Title changed from Polymorphic eager load does not care about full class name in <assoc_name>_type column to Full class name STI not included in eager loading
-
Christian Weyer
Fixed both of the bugs, attached a test. This test does not include tests since Josch's test are already there and working
-
Christian Weyer
Should not work late a night :)
I attached a patch, not a test. And this patch does not include tests since Josch's tests are working
-
wildchild
+1 this patch like a pain suppressor for me :)
-
Joachim Garth
+1, works nicely
-
Pratik
- Assigned user set to Pratik
-
Repository
- State changed from open to Resolved
(from [a1fcbd971d681e44de5ea33e6a8470ff8b8144c0]) Make sure association preloading works with full STI class name [#465 state:Resolved]
Signed-off-by: Pratik Naik
-
Repository
(from [c3aad223321d1897c9e2269b32c3c2da7af814d1]) Make sure association preloading works with full STI class name [#465 Full class name STI not included in eager loading state:Resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
