This project is archived and is in readonly mode.

#4679 ✓committed
Ernie Miller

Multiple self-referencing eager loads don't join properly

Reported by Ernie Miller | May 24th, 2010 @ 01:33 PM

This is from #4463 -- decided it's probably better to create a new ticket than submit a fix to an already committed ticket. I made a small, silly error in the previously committed patch, checking is_a? instead of class equality. Since JoinAssociation inherits from JoinBase, this can cause a stashed association join to be grafted onto the JoinBase instead of a JoinAssociation in the edge case of multiple-self-joining eager loads. Patch with test included. Sorry about that!

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Referenced by

Pages