This project is archived and is in readonly mode.
Multiple self-referencing eager loads don't join properly
Reported by Ernie Miller | May 24th, 2010 @ 01:33 PM
This is from #4463 -- decided it's probably better to create a new ticket than submit a fix to an already committed ticket. I made a small, silly error in the previously committed patch, checking is_a? instead of class equality. Since JoinAssociation inherits from JoinBase, this can cause a stashed association join to be grafted onto the JoinBase instead of a JoinAssociation in the edge case of multiple-self-joining eager loads. Patch with test included. Sorry about that!
Comments and changes to this ticket
-
Ernie Miller May 24th, 2010 @ 02:18 PM
- Tag changed from “joindependency, rails3” to “joindependency, patch, rails3, tests”
-
Ernie Miller June 8th, 2010 @ 12:33 AM
- Assigned user set to “Pratik”
Pratik, sorry for sending this your way but I don't want to see Rails 3 release with this silly bug :)
-
Repository June 8th, 2010 @ 06:02 AM
- State changed from “new” to “committed”
(from [a4eaa1fd39f93eff975bfd8a5cc4c7dfc3f18aa7]) Fix multiple self-referencing eager loads failing to join multiple times
[#4679 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/a4eaa1fd39f93eff975bfd8a5cc4c7...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Ernie Miller
Pratik
Santiago Pastorino
Attachments
Tags
Referenced by
-
4679
Multiple self-referencing eager loads don't join properly
[#4679 state:committed]