#4700 undefined method `protect_against_forgery?' for #<ActionView::Base:0x10ad1a500> - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4700 ✓resolved

undefined method `protect_against_forgery?' for #<ActionView::Base:0x10ad1a500>

Reported by David Chelimsky | May 26th, 2010 @ 07:08 AM

In a test for the new.html.erb template generated in the scaffold generator, rendering the template results in undefined method 'protect_against_forgery?'.

This is happening because new.html.erb renders _form.html.erb, which calls form_for, which calls FormTagHelper#extra_tags_for_form, which calls protect_from_forgery?, which is not defined in the scope in which it is being called.

I've got a patch that fixes this:
http://github.com/dchelimsky/rails/commit/53ba21a30fd359744cdee9acd...

Admittedly this is not perfect, but it does solve this problem without bleeding into other areas of the system.

Comments and changes to this ticket

You flagged this item as spam.
David Chelimsky May 26th, 2010 @ 07:09 AM
- Tag set to “action_view, patch, testing”
- Assigned user set to “José Valim”
You flagged this item as spam.
David Chelimsky May 26th, 2010 @ 07:10 AM
- Assigned user changed from “José Valim” to “Carl Lerche”
You flagged this item as spam.
David Chelimsky May 26th, 2010 @ 07:10 AM
- Assigned user changed from “Carl Lerche” to “Yehuda Katz (wycats)”
José Valim May 26th, 2010 @ 07:50 AM
David, I could not apply it. Could you please rebase?
You flagged this item as spam.
David Chelimsky May 26th, 2010 @ 12:05 PM
I forgot there were two commits on that branch. In the previous commit I rearranged the tests in test_case_test. Here are the two commits (in order):

http://github.com/dchelimsky/rails/commit/44fda04e9a5e2d19a412104b5...

http://github.com/dchelimsky/rails/commit/53ba21a30fd359744cdee9acd...

If you want, I can squash them into one commit. If not, they should apply cleanly in that order.

Obrigado,
David
Repository May 26th, 2010 @ 02:59 PM
- State changed from “new” to “resolved”
(from [e02db06ece7aeecec7c37f5b0e3de7d65c8684e6]) In AV::TC, move protect_against_forgery? from the test_case to the _helper module included in the view.
- ensures that protect_against_forgery? is present when a helper included in a partial that is rendered by the template under test calls it (which happens in FormTagHelper#extra_tags_for_form, for example).
[#4700 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/e02db06ece7aeecec7c37f5b0e3de7...