Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Ruby 1.8.x + I18N String Interpolation with % and %% and <

#4709

Upgrading from Rails 2.3.5 to Rails 2.3.8 exposed the following problem with the String#% method where interpolation is performed.

'%.0f<span>%%</span>' % 0.5

Expected result is "0<span>%</span> but instead there is an exception thrown:

malformed format string - %<

This is from the file:

activesupport/lib/active_support/vendor/i18n-0.3.7/i18n/core_ext/string/interpolate.rb

Where the line in question is:

result = gsub(/%([{<])/, '%%\1')

This is presumably trying to re-escape the angle-bracket style placeholders so they aren't evaluated. The problem is that this is ignoring already escaped % characters.

A possible fix for this is to make it not try and re-escape:

result = gsub(/%%?([{<])/, '%%\1')

Reported by tadman · May 26th, 2010 @ 04:54 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. tadman
    tadman

    Quick config/initializers patch for this specific issue: http://gist.github.com/414677

    May 26th, 2010 @ 05:00 PM

  2. tadman
    tadman
    • Tag changed from i18n activesupport interpolate rails 2.3.8 to active_support, i18n, interpolation, rails

    May 26th, 2010 @ 05:00 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:52 PM

  4. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:52 PM