This project is archived and is in readonly mode.
[PATCH] Minor: Add module_eval missing file_name and line_number args
There is one module_eval call in
active_record/autosave_association.rb which doesn't
follow passing __FILE__, __LINE__ + 1 arguments
convention used elsewhere, attached patch fixes that.
-
Santiago PastorinoI've cleaned up a lot of this things can you search for more like module_eval %{ or class_eval %{ , etc ...
Also do it for master and 2-3-stable.
Thanks. -
Evgeniy DolzhenkoExcluding tests that was the only place I was able to find where
module_eval/class_evaldidn't follow the conventions.Added patch against 2-3-stable which is particularly the same.
-
Santiago Pastorino
- Milestone cleared.
- Tag changed from activecord to 2.3.x, 3.0, activecord, patch
- State changed from new to open
- Assigned user set to Santiago Pastorino
-
Santiago Pastorino
- Assigned user changed from Santiago Pastorino to José Valim
- Importance changed from to Low
-
Repository
- State changed from open to resolved
(from [a39f2657b1ae8d61c6018766f8d250b1401beace]) Add module_eval missing file_name and line_number args [#4712 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/a39f2657b1ae8d61c6018766f8d250... -
Santiago Pastorino
- Milestone set to 2.3.9
- State changed from resolved to open
José we need to apply this for 2.3 too
-
José ValimOk, but in general, there is no need to apply such stuff in 2.3 eh? :)
-
Repository
- State changed from open to resolved
(from [56b35afbdd64a894e8efddda4651ef89ed7473b2]) Add module_eval missing file_name and line_number args
[#4712 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/56b35afbdd64a894e8efddda4651ef...