#4712 [PATCH] Minor: Add module_eval missing file_name and line_number args - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4712 ✓resolved

[PATCH] Minor: Add module_eval missing file_name and line_number args

Reported by Evgeniy Dolzhenko | May 27th, 2010 @ 11:35 AM | in 2.3.9

There is one module_eval call in active_record/autosave_association.rb which doesn't follow passing __FILE__, __LINE__ + 1 arguments convention used elsewhere, attached patch fixes that.

add_module_eval_missing_file_name_and_line_number_args.diff 1.1 KB

Comments and changes to this ticket

Santiago Pastorino May 27th, 2010 @ 12:04 PM
I've cleaned up a lot of this things can you search for more like module_eval %{ or class_eval %{ , etc ...
Also do it for master and 2-3-stable.
Thanks.
You flagged this item as spam.
Evgeniy Dolzhenko May 27th, 2010 @ 03:40 PM
Excluding tests that was the only place I was able to find where module_eval/class_eval didn't follow the conventions.

Added patch against 2-3-stable which is particularly the same.
- add_module_eval_missing_file_name_and_line_number_args_2_3.diff 1.1 KB
Santiago Pastorino May 27th, 2010 @ 03:59 PM
- Milestone cleared.
- Tag changed from “activecord” to “2.3.x, 3.0, activecord, patch”
- State changed from “new” to “open”
- Assigned user set to “Santiago Pastorino”
Santiago Pastorino June 26th, 2010 @ 08:42 PM
- Assigned user changed from “Santiago Pastorino” to “José Valim”
- Importance changed from “” to “Low”
Repository June 26th, 2010 @ 09:39 PM
- State changed from “open” to “resolved”
(from [a39f2657b1ae8d61c6018766f8d250b1401beace]) Add module_eval missing file_name and line_number args [#4712 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/a39f2657b1ae8d61c6018766f8d250...
Santiago Pastorino June 27th, 2010 @ 12:28 AM
- Milestone set to “2.3.9”
- State changed from “resolved” to “open”
José we need to apply this for 2.3 too
José Valim June 27th, 2010 @ 07:47 AM
Ok, but in general, there is no need to apply such stuff in 2.3 eh? :)
Repository June 27th, 2010 @ 07:53 AM
- State changed from “open” to “resolved”
(from [56b35afbdd64a894e8efddda4651ef89ed7473b2]) Add module_eval missing file_name and line_number args

[#4712 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/56b35afbdd64a894e8efddda4651ef...