This project is archived and is in readonly mode.
Fix url_for(nil) crashing
url_for(nil)
will be inferred as the nil_class_url named route - which doesn't exist 99% of the time causing an uncaught exception.
I wasn't trying to use this, just noticed the url_for helper method actually did accept a nil option while reading documentation:
when NilClass
url = @controller.send(:url_for, nil)
I looked back at http://dev.rubyonrails.org/ticke... and I made a guess that the best way to respond to a nil argument is to assume you want the current url.
Patch attached.
-
url_for_nil.diff
3.5 KB
-
Repository- State changed from new to resolved
- Tag set to actionpack, patch, tiny
(from [96708af6a58a48c2324a3bf8d34232bc29b398c9]) Ensure url_for(nil) falls back to url_for({}). [#472 state:resolved]
Signed-off-by: Pratik Naik
-
Repository
(from [4fa6615b15451fcdea17b33ebd78e3f4a848e4e7]) Ensure url_for(nil) falls back to url_for({}). [#472 Fix url_for(nil) crashing state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...