This project is archived and is in readonly mode.
Hard setting path_parameters in functional tests for monkey patching friendliness
ActionController::TestRequest#assign_parameters
should hard set path_parameters. This is so that
monkey patchers can safely override methods and use
params (or it's alias parameters) without
breaking functional tests.
Because of
the way parameters is implemented, as soon as it is called,
altering the contents of path_parameters has no effect
on parameters.
The current behavior is to alter path_parameters,
which will not as intended alter what parameters
returns, since it has already been set.
The issue is resolved by explicitly calling
path_parameters=.
See attached patch, with test case and fix.
-
August LilleaasNote: here is the real world monkey patch that caused this issue. http://gitorious.org/~augustl/gitorious/augustls-clone/commit/05206...
You can argue that the problem here is the horribly old plugin, and monkey patching in general :) But the change is pretty minor, and it makes sense to tighten up the implementation like this anyways.
-
August Lilleaas
Updated the test to call something more testable that makes more sense.
-
August Lilleaas
- Tag changed from actioncontroller, test to actioncontroller, rails3, test
-
August Lilleaas
Effectively closed by http://github.com/rails/rails/commit/9f93de9d3dd7db8de67cb0ee10ea03...
-
Ryan Bigg- State changed from new to resolved