Link_to should escape & in the query string

Here is the patch and its tests.

By the way, I think that the behaviour of url_for for escaping is weird. It escapes strings by default, but not hashes, even if the documentation wasn't saying that. It seems that there is a purpose for that as there was a commit specially for that (1b3195b63ca44f0a70b61b75fcf4991cb2fbb944), so I do not have modified this. But I was tempted.

I checked this and it does escape the ampersand

=link_to "Clickme", url_for(:controller => "posts", :action => "index")
=link_to "Clickme", url_for(:controller => "posts", :action => "index", :foo => "1", :bar => "2")
=link_to "Clickme", url_for(:controller => "posts", :action => "new", :foo => "1", :bar => "2")







<a href="/posts">Clickme</a>
<a href="/posts?bar=2&amp;foo=1">Clickme</a>
<a href="/posts/new?bar=2&amp;foo=1">Clickme</a>

I am using Rails 3 beta 4.

It generated this url,

=link_to_unless_current("Showing", {:order => "desc", :page => 2})
<a href="/posts?order=desc&page=2">Showing</a>

BTW

def hash_for(opts = {})

{:controller => "foo", :action => "bar"}.merge(opts)

end



hash_for does not escape, its a method in the url_helper_test.rb, url_for does the escaping

def hash_for(opts = {})
  {:controller => "foo", :action => "bar"}.merge(opts)
end