#4774 [PATCH] Exception.subclasses fails with syntax error - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4774 ✓stale

[PATCH] Exception.subclasses fails with syntax error

Reported by Wilson Bilkovich | June 5th, 2010 @ 09:28 PM

Here is an example of the failure: https://gist.github.com/b334efbd305d202ee05b

The problem is that 'fatal' is one of the subclasses of Exception. It has a name ('fatal'), and therefore the current implementation of 'subclasses' on 2-3-stable tries to run 'defined?(::fatal)', which is not valid syntax on any version of Ruby.

Patch is against 2-3-stable, since 3.0 uses a different (better) technique.

I chose to special-case 'fatal' since it isn't like there are a lot of lower-cased classes floating around out there.

exception_subclasses.diff 2 KB

Comments and changes to this ticket

You flagged this item as spam.
Wayne Seguin June 5th, 2010 @ 09:31 PM
This is definitely a needed patch IMHO. +1!
David Trasbo July 28th, 2010 @ 06:42 PM
- Assigned user set to “José Valim”
+1 from here too. Assigning it to José. Maybe he'll apply it.
You flagged this item as spam.
Andrea Campi October 11th, 2010 @ 07:24 AM
- Tag changed from “active_support core_ext, 2.3-stable, patched” to “active_support core_ext, 2.3-stable, patch”
bulk tags cleanup
José Valim October 11th, 2010 @ 11:28 PM
- State changed from “new” to “stale”
- Importance changed from “” to “Low”