This project is archived and is in readonly mode.

#4796 ✓committed
Evgeniy Dolzhenko

[PATCH] Fix a bunch of minor spelling mistakes

Reported by Evgeniy Dolzhenko | June 8th, 2010 @ 07:02 PM

Hey! I've spent a few hours and tried to weed out last minor spelling
mistakes from the Rails code base.

Also removed some gratuitous unicode usage in comments.

Comments and changes to this ticket

  • Evgeniy Dolzhenko

    Evgeniy Dolzhenko June 8th, 2010 @ 07:02 PM

    • Tag changed from 3.x to 3.x, patch
  • Evgeniy Dolzhenko
  • Xavier Noria

    Xavier Noria June 15th, 2010 @ 10:10 AM

    • State changed from “new” to “committed”

    Awesome, will be merged into master sometime today. Thanks!

  • Eloy Duran

    Eloy Duran June 15th, 2010 @ 11:31 AM

    As I said in the commit comments, imo the unicode characters should not be removed. Their definitely not gratuitous, but exactly what they’re meant for. Is there a technical problem? For instance, the API docs are all generated with --charset utf-8, so that shouldn't be any problem at all.

    However, I can imagine that apostrophes might be ‘normalized’ to the basic ASCII version, as it probably only looks nice if it’s being used consistent.

    Addendum: This is all more of a philosophical comment. Whatever is decided upon is fine by me, I personally just prefer the looks of docs with proper (unicode) punctuation and dislike getting rid of unicode chars for the sake of getting rid of them :)

  • Evgeniy Dolzhenko

    Evgeniy Dolzhenko June 15th, 2010 @ 11:38 AM

    My only concern was that the files didn't have Ruby Unicode headers while still having Unicode characters in them. I decided it was easier to replace them instead of adding proper headers.

  • Eloy Duran

    Eloy Duran June 15th, 2010 @ 11:43 AM

    Gotcha. Which makes me wonder, would it be a good/bad idea to add the magic utf8 encoding comments to all source files?

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>