Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

label tag ignoring for attribute

#48

When using the label method on a form builder, it seems useful to be able to manually set a for attribute. Currently the to_label_tag method will either override the for user-specified option, if it is specified as a string key, or it will put two for attributes in the generated html if the user supplies a symbol key.

I am including a patch that I believe fills this gap, along with a pair of tests.

This is my first patch submission, so if I've missing something, please instruct me for next time, thanks. :)

Reported by encoded · April 25th, 2008 @ 11:54 PM

State: resolved
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. encoded
    encoded

    Hrm, I seem to be unable to add an attachment... I selected my patch file in the Upload Attachment field, but it did not appear with the ticket... Any idea what I'm missing?

    April 25th, 2008 @ 11:57 PM

  2. encoded
    encoded

    Ah, the attachment was there the whole time, I just didn't see it over on the right-hand side. Sorry.

    April 25th, 2008 @ 11:57 PM

  3. josh
    josh
    • Assigned user set to josh

    April 30th, 2008 @ 11:15 PM

  4. DHH
    DHH
    • State changed from new to resolved

    May 1st, 2008 @ 05:26 AM