This project is archived and is in readonly mode.
Can't create a route with an prefix optional segment that contains both static and dynamic parts
-
Paul Barry
Here's a patch with a failing test
-
Paul Barry
- Tag changed from rails3 routes to rails3 routes, patch
Ok, looks like the problem is with the regexp in the normalize_path method in Mapper, it only works for routes like
(/:foo)/whatever, not(/foo/:bar)/whatever. I've attached a patch that should fix it. -
Andrew White
- Assigned user set to Andrew White
Paul, can you rebase your patch against the latest HEAD?
-
Paul Barry
@Andrew
Here you go!
-
Andrew White
- State changed from new to open
- Milestone cleared.
- Importance changed from to High
Thanks Paul. I've taken your patch and extended it to also support optional static segments by themselves as well.
-
Repository
- State changed from open to resolved
(from [d4e1a2ef0d35f322803284a980575fc31ff7b4b6]) Support optional static segements as well [#4832 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d4e1a2ef0d35f322803284a980575f... -
José Valim
Both patches applied! Thanks guys!
