Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Paul Barry

Paul Barry

Not a member

Paul Barry's latest activity

Saturday, June 26 2010
4832 Can't create a route with an prefix optional segment that contains both stati... was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 3:03 AM

    @Andrew

    Here you go!
Saturday, June 12 2010
4838 [PATCH] Add Block Support to ActiveSupport OrderedHash merge was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 4:29 AM

    This looks good. I've attached a patch that re-organizes the test for merge into a few smaller tests.
4803 [PATCH] remove_column should raise an ArgumentError when no columns are passed was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 4:11 AM

    Jeff,

    You're right, I completely was looking at the wrong thing. Raising an ArgumentError here completely makes sense if column_names is empty, which is what th...
  • Paul Barry
    Paul Barry commented at 3:30 AM

    I've looked at this one for a while and I'm totally baffled as to why is doesn't just raise a MySQL exception anyway. If you try to drop a column that doesn't e...
4809 [PATCH] Table name not escaped on dropping index was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 4:05 AM

    Looks good, it's definitely a bug that should be fixed. I've attached a new patch that slightly modifies the test so that it asserts that no exception is raised...
4777 render(:inline) in a layout before yield replaces original content was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 3:40 AM

    +1, applies cleanly, resolves the issue
4839 [PATCH] form fields should allow developers to set values to nil was updated in Ruby on Rails
  • Paul Barry
    Paul Barry commented at 2:01 AM

    +1

    Patch applies cleanly, looks good. Make sense to me too, I would expect providing an explicit value would override the value of the object.

    Out of curiosity,...
4836 [PATCH] Inconsistent behavior in pluralizing uncountable words was updated in Ruby on Rails
  • Paul Barry
    • Tag changed from activesupport, inflections to activesupport, inflections, patch
    by Paul Barry at 1:33 AM

    This patch looks good. There's obviously a bug that the test shows which is that existing compound word string, so a word like WhiteRice, is incorrectly plurali...
Friday, June 11 2010
4832 Can't create a route with an prefix optional segment that contains both stati... was updated in Ruby on Rails
  • Paul Barry
    • Tag changed from rails3 routes to rails3 routes, patch
    by Paul Barry at 10:32 PM

    Ok, looks like the problem is with the regexp in the normalize_path method in Mapper, it only works for routes like (/:foo)/whatever, not (/foo/:bar)/whatever. ...
  • Paul Barry
    Paul Barry commented at 8:57 PM

    Here's a patch with a failing test