This project is archived and is in readonly mode.

#4846 ✓stale
Chris

Helpers for specifying body attributes for the layout

Reported by Chris | June 12th, 2010 @ 08:28 PM

Often a template/partial needs to access the attributes of a body tag.

The attached patch enables a convention that body tags should have an ID and class that makes it easier to scope unobtrusive stylesheets or javascript to a part of an application. The default id and class attributes are based on the controller path and action.

This patch also provides a simple mechanism for overriding the default body attributes thru repeated calls to add_body_attributes which may occur anywhere in the main template or in included partials.

Additionally, the facilities needed for merging tag attributes on the body tag are exposed as general tag helper methods that can be used to compose attributes for any tag.

This patch is an extraction of a pattern that I've used in just about every rails app that I've created in the past three years -- I find this to be an extremely useful and maintainable way of managing the body tag.

Comments and changes to this ticket

  • Chris

    Chris June 12th, 2010 @ 08:29 PM

    If it's useful for review or merging, here's the branch with this changeset:

    http://github.com/chriseppstein/rails/commits/body_attributes

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:37 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages