This project is archived and is in readonly mode.
avoid warning: method redefined; discarding old <=>
-
-
Ryan Bigg- Milestone set to 3.x
- State changed from new to open
+1
Patch applies cleanly and warnings are gone from the activesupport tests. Going to assume they're gone from the others too.
-
Lenary
Sorry, for clarification, i'm using ruby 1.8.7p249
the warnings appear in the following test suites:
- activesupport
- activemodel
- actionmailer
- activerecord MySQL tests
- activerecord PostgreSQL tests
- activerecord SQLite3 tests
-
David Trasbo+1
As Ryan says, the patch applies cleanly.
-
Santiago Pastorino- Milestone cleared.
- Assigned user set to Yehuda Katz (wycats)
Good work Sam, anyways seems like the <=> method is defined twice when you're on < 1.9 so i think the proper fix is this one.
http://github.com/spastorino/rails/commit/f592c41accdf87d6c65a5cf42...
Correct me if i'm wrong. -
Lenary
Indeed you are correct Santiago, though please add me into the authors of that patch.
-
Santiago Pastorino
Sure no problem i was added you as Hat Tip but now you're the author ;).
http://github.com/spastorino/rails/commit/d2e3aab4e576aca57af793adc... -
Santiago Pastorino
- Assigned user changed from Yehuda Katz (wycats) to José Valim
As requested by Brosé!
-
Santiago Pastorino
I'm uploading the patch file here because i need to rebase my repo ;).
-
Repository
- State changed from open to committed
(from [02ea1aa88ce92ee3fa0cc87c719f6fc6c1428bcc]) <=> is defined twice on multibyte/chars.rb for Ruby < 1.9
[#4850 avoid warning: method redefined; discarding old <=> state:committed]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/02ea1aa88ce92ee3fa0cc87c719f6f... -
