#4850 avoid warning: method redefined; discarding old <=> - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4850 ✓committed

avoid warning: method redefined; discarding old <=>

Reported by Lenary | June 13th, 2010 @ 12:23 PM | in 3.0.2

When running the test suite, there are lots of warnings.

One of these is warning: method redefined; discarding old <=>

I shall provide a patch shortly

Comments and changes to this ticket

You flagged this item as spam.
Lenary June 13th, 2010 @ 12:26 PM
Added a patch
- remove_warnings.diff 1.1 KB
Ryan Bigg June 13th, 2010 @ 12:38 PM
- Milestone set to “3.x”
- State changed from “new” to “open”
+1

Patch applies cleanly and warnings are gone from the activesupport tests. Going to assume they're gone from the others too.
You flagged this item as spam.
Lenary June 13th, 2010 @ 12:50 PM
Sorry, for clarification, i'm using ruby 1.8.7p249

the warnings appear in the following test suites:
- activesupport
- activemodel
- actionmailer
- activerecord MySQL tests
- activerecord PostgreSQL tests
- activerecord SQLite3 tests
David Trasbo June 13th, 2010 @ 07:18 PM
+1

As Ryan says, the patch applies cleanly.
Santiago Pastorino June 14th, 2010 @ 01:07 AM
- Milestone cleared.
- Assigned user set to “Yehuda Katz (wycats)”
Good work Sam, anyways seems like the <=> method is defined twice when you're on < 1.9 so i think the proper fix is this one.
http://github.com/spastorino/rails/commit/f592c41accdf87d6c65a5cf42...
Correct me if i'm wrong.
You flagged this item as spam.
Lenary June 14th, 2010 @ 09:13 AM
Indeed you are correct Santiago, though please add me into the authors of that patch.
Santiago Pastorino June 15th, 2010 @ 10:40 PM
Sure no problem i was added you as Hat Tip but now you're the author ;).
http://github.com/spastorino/rails/commit/d2e3aab4e576aca57af793adc...
Santiago Pastorino June 15th, 2010 @ 10:45 PM
- Assigned user changed from “Yehuda Katz (wycats)” to “José Valim”
As requested by Brosé!
Santiago Pastorino June 16th, 2010 @ 10:10 PM
I'm uploading the patch file here because i need to rebase my repo ;).
- is-defined-twice-on-multibyte-charsrb-for-ruby-19.patch 2.3 KB
Repository June 19th, 2010 @ 11:59 PM
- State changed from “open” to “committed”
(from [02ea1aa88ce92ee3fa0cc87c719f6fc6c1428bcc]) <=> is defined twice on multibyte/chars.rb for Ruby < 1.9

[#4850 state:committed]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/02ea1aa88ce92ee3fa0cc87c719f6f...
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]