#4855 layout inheritance broken with :only - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4855 ✓wontfix

layout inheritance broken with :only

Reported by dorren | June 14th, 2010 @ 02:49 AM

If I have in application_controller.rb:

layout 'standard'

and in some_controller.rb

layout 'special', :only=>[:a, :b, :c]

All other actions in some_controller will use NO template at all, rather than using the 'standard' layout specified in application.rb. Actions not in :only, or in :except should inherit application.rb's layout IMO.

All text above is copied from http://dev.rubyonrails.org/ticket/3647 . This is a 4 years old ticket, and still affecting rails 2.3.4, possibly 2.3.5 as well.

Comments and changes to this ticket

You flagged this item as spam.
dorren June 14th, 2010 @ 03:25 AM
patch for 2-3-stable branch, see attached, thanks.

patch is created per https://rails.lighthouseapp.com/projects/8994/sending-patches
- b-4855-layout-inheritance.diff 3.5 KB
José Valim June 22nd, 2010 @ 04:26 PM
- State changed from “new” to “wontfix”
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
José Valim June 22nd, 2010 @ 04:26 PM
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
José Valim June 22nd, 2010 @ 04:26 PM
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
José Valim June 22nd, 2010 @ 04:27 PM
Great, LH got my comment three times! Sorry about it!