Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

layout inheritance broken with :only

#4855

If I have in application_controller.rb:

layout 'standard'

and in some_controller.rb

layout 'special', :only=>[:a, :b, :c]

All other actions in some_controller will use NO template at all, rather than using the 'standard' layout specified in application.rb. Actions not in :only, or in :except should inherit application.rb's layout IMO.

All text above is copied from http://dev.rubyonrails.org/ticket/3647 . This is a 4 years old ticket, and still affecting rails 2.3.4, possibly 2.3.5 as well.

Reported by dorren · June 14th, 2010 @ 02:49 AM

State: wontfix
Milestone: none
Assigned to: nobody
Importance: Low

Activity

  1. dorren
    dorren

    patch for 2-3-stable branch, see attached, thanks.

    patch is created per https://rails.lighthouseapp.com/projects/8994/sending-patches

    June 14th, 2010 @ 03:25 AM

  2. José Valim
    José Valim
    • State changed from new to wontfix

    Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

    I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.

    June 22nd, 2010 @ 04:26 PM

  3. José Valim
    José Valim

    Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

    I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.

    June 22nd, 2010 @ 04:26 PM

  4. José Valim
    José Valim

    Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.

    I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.

    June 22nd, 2010 @ 04:26 PM

  5. José Valim
    José Valim

    Great, LH got my comment three times! Sorry about it!

    June 22nd, 2010 @ 04:27 PM