This project is archived and is in readonly mode.
layout inheritance broken with :only
Reported by dorren | June 14th, 2010 @ 02:49 AM
If I have in application_controller.rb:
layout 'standard'
and in some_controller.rb
layout 'special', :only=>[:a, :b, :c]
All other actions in some_controller will use NO template at all, rather than using the 'standard' layout specified in application.rb. Actions not in :only, or in :except should inherit application.rb's layout IMO.
All text above is copied from http://dev.rubyonrails.org/ticket/3647 . This is a 4 years old ticket, and still affecting rails 2.3.4, possibly 2.3.5 as well.
Comments and changes to this ticket
-
dorren June 14th, 2010 @ 03:25 AM
patch for 2-3-stable branch, see attached, thanks.
patch is created per https://rails.lighthouseapp.com/projects/8994/sending-patches
-
José Valim June 22nd, 2010 @ 04:26 PM
- State changed from “new” to “wontfix”
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.
I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
-
José Valim June 22nd, 2010 @ 04:26 PM
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.
I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
-
José Valim June 22nd, 2010 @ 04:26 PM
Dorren, thanks for your patch! However, I don't think we should change it on Rails 2.3 branch, because it's a maintenance branch and people may be relying on this wrong behavior.
I'm closing this issue, but if you want to bring this functionality to Rails 3, I will be glad to reopen this ticket and apply your new patch.
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
dorren
Jeremy Kemper
José Valim