This project is archived and is in readonly mode.
resouces :only => :create broken since :shallow added
-
Josh Kalderimis
This issue is bigger than just create and includes update and destroy, I have a patch nearly finished which should cover all cases.
-
Josh Kalderimis
Patch supplied with broader tests for :update, :destroy and :create helper methods not being generated when :shallow and :only or :except are used together.
-
Andrew White
Nearly Josh, but you forget the lonely old singleton resource - good catch though.
The attached patch is basically the same as yours - I just aliased collection_name on SingletonResource to member_name.
-
Josh Kalderimis
Hi Andrew,
Thanks for the feedback! :)
Am I able to also get credited in this patch?
Thanks,
Josh
-
Josh Kalderimis
Hi Andrew, (again)
I see that your patch is minus tests for :only => :update and :delete, is your patch a replacement to mine, or are they to be used together?
Thanks
Josh
-
Andrew White
Josh, by all means come up with a new patch with more extensive tests and then your patch can get applied and you'll get the credit.
-
Josh Kalderimis
Updated patch with correction for singular routes and broader test coverage (again) :)
-
Repository
- State changed from new to committed
(from [9d3eeb905341aaad942ceb0e47bd04cced34d031]) fix for :shallow in router not generating helpers for create, update, and destroy actions when :only or :except are used
[#4900 resouces :only => :create broken since :shallow added state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/9d3eeb905341aaad942ceb0e47bd04... -
José Valim
You guys rock! :)
