This project is archived and is in readonly mode.
AS::Multibyte::Chars: Don't override methods that work properly in 1.9.2
Reported by Norman Clarke | June 26th, 2010 @ 04:02 AM | in 3.0.2
A recent patch of mine made String#mb_chars use a proxy class for 1.9.x. This class overrode some methods that were buggy in 1.9.1. but that work in 1.9.2.
Since Rails officially now only supports 1.8.7 and 1.9.2, these methods should no longer be overridden. The patch I'll attach fixes this issue.
Comments and changes to this ticket
-
Norman Clarke June 26th, 2010 @ 04:06 AM
- Tag changed from “1.9.2, activesupport, multibyte” to “1.9.2, activesupport, multibyte, patch”
-
Santiago Pastorino June 26th, 2010 @ 04:39 AM
- Milestone cleared.
- State changed from “new” to “verified”
- Assigned user set to “José Valim”
-
Repository June 26th, 2010 @ 11:10 AM
- State changed from “verified” to “resolved”
- Importance changed from “” to “Low”
(from [cfaaed3f40e820d2b4d60c2d8bc1f9a005cee086]) Move some methods into 1.8.x-only proxy. [#4978 state:resolved]
These methods had been overridden because they had bugs on 1.9.1. Since
Rails now supports only 1.9.2, and these methods now work properly on
that version, there's no longer any need to override them.Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/cfaaed3f40e820d2b4d60c2d8bc1f9... -
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeremy Kemper
José Valim
Santiago Pastorino
Attachments
Tags
Referenced by
-
4978
AS::Multibyte::Chars: Don't override methods that work properly in 1.9.2
(from [cfaaed3f40e820d2b4d60c2d8bc1f9a005cee086])
Move so...