[PATCH] Integration test incompatible w/ Session store when multiple cookies

With Rails 2.3.8 ... (traced to http://github.com/rails/rails/commit/f85ab90e4fbe38ac5ad211d07a8113...)

If you have a rails app that uses any session store that subclasses AbstractStore, and also sets some other type cookie.

Then your integration tests will fail to properly pass your session data from one response to the next request.

class MemCacheStoreTest < ActionController::IntegrationTest
  class TestController < ActionController::Base

...

    def set_session_value_and_a_cookie
      cookies[:foo] = "cookie bar"
      session[:foo] = "session bar"
      head :ok
    end

...

    def test_setting_and_getting_session_value_and_also_a_cookie
      with_test_route_set do
        get '/set_session_value_and_a_cookie'
        assert_response :success
        assert cookies['_session_id'], 
          "Expected to have a '_session_id' cookie, but got #{cookies.inspect}"

        get '/get_session_value'
        assert_response :success
        assert_equal 'foo: "session bar"', response.body
      end
    end

If you run this, you'll get:

1) Failure: test_setting_and_getting_session_value_and_also_a_cookie(MemCacheStoreTest)
Expected to have a '_session_id' cookie, but got {"\n_session_id"=>"7d5797615e8faaadc007df328ed93ee7", "foo"=>"cookie+bar"}.

And so the fix is either to fix Integration test harness to ignore this extra "\n"

          cookies = @headers['Set-Cookie']
          cookies = cookies.to_s.split("\n") unless cookies.is_a?(Array)
          cookies.each do |cookie|
            # old way
            # name, value = cookie.match(/^([^=]*)=([^;]*);/)[1,2]
            # 'fixed' way
            name, value = cookie.match(/^[\n]?([^=]*)=([^;]*);/)[1,2]
            @cookies[name] = value
          end

OR, maybe this is a bug in abstract session store? But this is just a problem for people writing integration tests and seems to work fine with real web browsers.

But, still, I'm curious why AbstractStore prepends the extra "\n"

...
    class AbstractStore
...
      def call(env)
...
          unless headers[SET_COOKIE].blank?
            headers[SET_COOKIE] << "\n#{cookie}"
          else
            headers[SET_COOKIE] = cookie
          end
...