This project is archived and is in readonly mode.
proper "Usage:" messages for "rails plugin" commands
Reported by Akira Matsuda | July 4th, 2010 @ 11:20 AM
Firstly, executing the following command prints unnecessary
"Unknown command:".
% rails plugin
Next, commands below do nothing neither print nothing. In these
cases, it might be better printing the usage.
% rails plugin install
% rails plugin remove
So, here's the patches for those tiny problems.
Comments and changes to this ticket
-
Neeraj Singh July 7th, 2010 @ 06:06 PM
- Importance changed from “” to “Low”
@Akira between all the blank lines getting removed and being added it is hard to see the real change. May be you want to split your patch into two: one with real changes and one with the blank line changes you want.
-
Akira Matsuda July 7th, 2010 @ 09:27 PM
@Neeraj Yes, the patch file contains three commits.
Could you please
after% git log -p
the patch?% git am
Or do I have to separate the patch file? -
Neeraj Singh July 7th, 2010 @ 09:36 PM
@Akira all the changes related to a common thing should be in one single commit.
So I would suggest you to have two commits.
- One for all business functionality change.
- and the other for formatting changes.
-
Akira Matsuda July 7th, 2010 @ 11:07 PM
@Neeraj
Can't agree for this. This is really a dangerous habit for a team development.
all the changes related to a common thing should be in one single commit
Keep in mind that atomicity of the commits is the most important thing in order to avoid the conflict hell.
That's what Junio says.But anyway, I should agree that I made my commits too specific in this case.
Attached a new patch squashing two commits as you suggested.
Thanks! -
Repository July 8th, 2010 @ 12:21 AM
- State changed from “new” to “committed”
(from [bf5d15456757e63598575db42917d702af9da729]) Print proper "Usage:" messages for "rails plugin" command
- suppress outputting "Unknown command:" when no command were specified
- output the "Usage:" message when no plugin names were given
[#5043 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/bf5d15456757e63598575db42917d7...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Akira Matsuda
Jeremy Kemper
Neeraj Singh
Attachments
Referenced by
-
5043
proper "Usage:" messages for "rails plugin" commands
[#5043 state:committed]