This project is archived and is in readonly mode.
[PATCH] bug in #construct_quoted_owner_attributes at ActiveRecord::Associations::ThroughAssociationScope
-
Neeraj Singh
- Milestone set to 3.x
- Assigned user set to José Valim
- State changed from new to open
- Tag set to activerecord, patch, rails3
- Importance changed from to Low
Attached is test cases for the patch.
-
José Valim
Will, could you please provide a patch following the conventions at: http://rails.lighthouseapp.com/projects/8994/sending-patches
Thanks!
-
José Valim
- Title changed from [PATCH] bug in ActiveRecord::Associations::ThroughAssociationScope#construct_quoted_owner_attributes to [PATCH] bug in #construct_quoted_owner_attributes at ActiveRecord::Associations::ThroughAssociationScope
-
Will St. Clair
Neeraj --
Thanks for the tests! Working on this today and pulled latest rails and now there is a conflict between the patch and your commits to rails core. Any preference on how I resolve this?
Thanks,
Will -
Will St. Clair
Ah, I see more clearly now; I will just rename Car in the patch to something else to avoid conflicting with your fix for 4984
-
Will St. Clair
Ok, patch + tests are attached.
-
Repository
- State changed from open to resolved
(from [b520d602ffb85f3816f4407ff9dd5c7721a2da7d]) string IDs are now quoted correctly [#5064 [PATCH] bug in #construct_quoted_owner_attributes at ActiveRecord::Associatio... state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/b520d602ffb85f3816f4407ff9dd5c...
