This project is archived and is in readonly mode.
duplicate test name
test/cases/associations/has_many_associations_test.rb
line 68
line 552
have same test name
test_find_or_create
i am attaching patch with this mail to rename the second test
-
rename_test.diff
1.09 KB
-
Neeraj Singh- Milestone set to 3.x
- Assigned user changed from Neeraj Singh to José Valim
- State changed from new to open
- Importance changed from to Low
+1 looks good to me
-
Subbapatch is for 2-3-stable.
-
Neeraj Singh
I see the same issue in rails master. Can you create a patch for rails master.
-
-
Rohit Arondekar+1 both tests have the same name! Patch fixes this.
-
Repository
- State changed from open to resolved
(from [44e7fba59e251c1eb12d8f793a643b5804cb3977]) renaming test name to fix accidently override
[#5076 duplicate test name state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/44e7fba59e251c1eb12d8f793a643b... -
-
Rohit Arondekar
- State changed from resolved to open
-
Repository
- State changed from open to resolved
(from [dec2c4f4e340b60e69e1a88cb6cf46c34c940244]) renaming test name to fix accidently override [#5076 duplicate test name state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/dec2c4f4e340b60e69e1a88cb6cf46...