Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

form.fields_for :attribute does not show when attribute is nil

#5114

The lighthouse formatting is not working correctly, so I put on gist the sample, test and fix:
http://gist.github.com/476057

Reported by marcos.neves (at gmail) · July 14th, 2010 @ 10:01 PM

State: stale
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Łukasz Strzałkowski
    Łukasz Strzałkowski

    Hi Marcos,

    I see that you have solved problem and now how to fix it. Please read contributor guide - http://rails.lighthouseapp.com/projects/8994/sending-patches and create patch for it :)

    July 15th, 2010 @ 09:43 PM

  2. marcos.neves (at gmail)
    marcos.neves (at gmail)

    I could not run the tests, cause the environment required was hard to setup.
    Sorry, this is my first patch.

    August 1st, 2010 @ 09:01 PM

  3. marcos.neves (at gmail)
    marcos.neves (at gmail)
    • Assigned user set to José Valim

    Now I was able to run the tests, and its ok.

    August 30th, 2010 @ 02:14 AM

  4. José Valim
    José Valim
    • Importance changed from to Low

    Your patch breaks actionpack tests.

    September 1st, 2010 @ 08:56 AM

  5. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:49 PM

  6. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:49 PM