This project is archived and is in readonly mode.
[PATCH] DHH forgot to remove JS, CSS in generated index.html
Reported by johan_lunds | July 31st, 2010 @ 01:48 PM
When removing the search-box in
railties/lib/rails/generators/rails/app/templates/public/index.html
the corresponding JS- and CSS-code was left there. I noticed this
in my webdev-console in Chrome because the JS threw a
TypeError
.
Relevant commit http://github.com/rails/rails/commit/2f398f23d68da41c058a9b8b27b2bd....
I'll put up a formatted patch here refencing the Lightouse ticket.
Comments and changes to this ticket
-
johan_lunds July 31st, 2010 @ 01:52 PM
- Tag changed from css, generated, html, javascript, regression to css, generated, html, javascript, patch, regression
-
johan_lunds July 31st, 2010 @ 01:53 PM
- Title changed from DHH forgot to remove JS, CSS in generated index.html to [PATCH] DHH forgot to remove JS, CSS in generated index.html
-
Repository August 1st, 2010 @ 12:39 AM
- State changed from new to resolved
(from [96f8325116148848cf2a6ec7d8561df8955ffaa3]) DHH forgot to remove JS, CSS in generated index.html [#5261 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/96f8325116148848cf2a6ec7d8561d...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 5261 [PATCH] DHH forgot to remove JS, CSS in generated index.html (from [96f8325116148848cf2a6ec7d8561df8955ffaa3]) DHH for...