This project is archived and is in readonly mode.
ActiveRecord::Base.abstract_class? should return false not nil
Although this doesn't break anything, but ActiveRecord::Base.abstract_class? returns nil when @abstract_class is not defined. This still works as nil and false are treated as false in conditionals. But Ruby methods ending with a ?, by convention should return true/false. The attached patch ensures that it does return false if @abstract_class is not defined.
IMHO no test was needed as the existing tests cover the functionality provided by the method.
Credit: Neeraj Singh for originally spotting the discrepancy.
-
abstract_class.diff
899 Bytes
-
Neeraj SinghI think you should add the test that method returns false and not nil :-)
-
-
Rohit Arondekar
- State changed from new to invalid
This is actually not needed as both nil and false behave the same. Also it's acceptable that a method ending with a ? return either nil or false if the condition is not satisfied. Closing ticket. :)
-
