This project is archived and is in readonly mode.
no callbacks should be created for empty only option
Callback module creates all callbacks if empty array is provided
for only option.
example.
define_model_callbacks :empty, :only => []
creates all three after, before,around filters.
this patch fixes this issue.
-
empty_only.diff
2.49 KB
-
Subba- Assigned user changed from Santiago Pastorino to José Valim
-
-
Subba
what if some meta programming construct creates empty array. you don't want it to create callbacks.
-
José Valim
- State changed from new to invalid
If this is the case, I would prefer to raise an error. It makes no sense such construct and I can't see a reason to be worried about such special case.
-
Subba
do you want me to change the patch to raise an error. or leave the code in current form.
-
José Valim
- State changed from invalid to new
- Milestone set to 3.x
Sorry, I marked it as invalid by mistake. I will actually apply the current patch since raising an error would just add even more lines of code. :) Thanks!
-
Repository
- State changed from new to resolved
(from [f8f437191f1cbf37ba842038164c1b873dc453e9]) no callbacks should be created for empty array [#5289 no callbacks should be created for empty only option state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f8f437191f1cbf37ba842038164c1b...