This project is archived and is in readonly mode.

#5298 ✓stale
Samuel Kadolph

Rails::Application deprecation warning gets caller wrong

Reported by Samuel Kadolph | August 4th, 2010 @ 06:14 PM

In rails 3.0.0.rc, using Rails::Application has had a deprecation warning added opting instead for Rails.application. The current code that calls the warning isn't capturing the right line of code of the offender.

Calling a method on Rails::Application that is fulfilled with method_missing calls the method instance where the warning is located. caller is used for the warning and at the time has the method_missing call at the top of the stack which is then used to display the warning location.

def HomeController < ApplicationController
  def index
    Rails::Application
  end
end

Current warning:

DEPRECATION WARNING: Calling a method in Rails::Application is... (called from method_missing at .../railties-3.0.0.rc/lib/rails/application.rb:77)

The correct warning should be this:

DEPRECATION WARNING: Calling a method in Rails::Application is... (called from index at .../app/controllers/home_controller.rb:5)


I don't know if it's a good solution, but I fixed it quickly by changed the caller argument in railties-3.0.0.rc/lib/rails/application.rb on line 54 to

"please call ...snip... #{Rails.application.class.name}.", caller[1..-1]

Comments and changes to this ticket

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:00 PM

    • State changed from “new” to “open”
    • Tag changed from rails 3.0.0.rc, rails3rc to rails 300rc, rails3rc

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 05:00 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages