Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

references_eager_loaded_tables? matches numbers with decimals

#532

ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? will return true if any decimal numbers exist in the query. This is due to the conditions_tables, order_tables, and selects_tables methods not being very discriminating in their Regexps. I'll be submitting a patch for this soon.

Reported by Peter Wagenet · July 2nd, 2008 @ 02:26 AM

State: resolved
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Peter Wagenet
    Peter Wagenet
    • Tag changed from activerecord, bug, eager_loading to activerecord, bug, eager_loading, patch

    Patch included now.

    July 3rd, 2008 @ 02:29 AM

  2. Pratik
    Pratik
    • State changed from new to incomplete

    Hi Peter,

    Your patch is missing tests. Could you please add a failing test case as well ? ( which will fail before applying the fix and pass afterwards )

    Thanks.

    July 4th, 2008 @ 12:20 AM

  3. Peter Wagenet
    Peter Wagenet

    Added a test for this. Sorry for the delay.

    July 14th, 2008 @ 05:46 PM

  4. Peter Wagenet
    Peter Wagenet

    Is there anything else delaying this from being approved?

    August 18th, 2008 @ 04:01 PM

  5. Pratik
    Pratik
    • State changed from incomplete to open
    • Tag changed from activerecord, bug, eager_loading, patch to activerecord, bug, eager_loading, patch, tested

    August 18th, 2008 @ 04:34 PM

  6. Repository
    Repository
    • State changed from open to resolved

    (from [8622787f8748434b4ceb2b925a35b17a38e1f2d6]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 references_eager_loaded_tables? matches numbers with decimals state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    August 21st, 2008 @ 05:24 PM

  7. Repository
    Repository

    (from [104220ed2c2c2ed67100f5022cd538e3e9f1acec]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 references_eager_loaded_tables? matches numbers with decimals state:resolved]

    Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...

    August 25th, 2008 @ 09:31 AM