This project is archived and is in readonly mode.
references_eager_loaded_tables? matches numbers with decimals
-
Peter Wagenet
- Tag changed from activerecord, bug, eager_loading to activerecord, bug, eager_loading, patch
Patch included now.
-
Pratik
- State changed from new to incomplete
Hi Peter,
Your patch is missing tests. Could you please add a failing test case as well ? ( which will fail before applying the fix and pass afterwards )
Thanks.
-
Peter Wagenet
Added a test for this. Sorry for the delay.
-
Peter Wagenet
Is there anything else delaying this from being approved?
-
Pratik
- State changed from incomplete to open
- Tag changed from activerecord, bug, eager_loading, patch to activerecord, bug, eager_loading, patch, tested
-
Repository
- State changed from open to resolved
(from [8622787f8748434b4ceb2b925a35b17a38e1f2d6]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 references_eager_loaded_tables? matches numbers with decimals state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
-
Repository
(from [104220ed2c2c2ed67100f5022cd538e3e9f1acec]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 references_eager_loaded_tables? matches numbers with decimals state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
