#5330 postgres adapter error when passing an array to IN statement - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5330 ✓stale

postgres adapter error when passing an array to IN statement

Reported by Sean | August 7th, 2010 @ 07:20 PM

The following simple query:

 User.where('id IN ?',[1,2])

generates the following incorrect SQL syntax, when using Postgres:

 SELECT     "users".* FROM       "users" WHERE     (id IN 1,2)

which causes postgres to give a syntax error:

  PGError: ERROR:  syntax error at or near "1"
  LINE 1: ...ELECT     "users".* FROM       "users" WHERE     (id IN 1,2)

It should generate

  SELECT     "users".* FROM       "users" WHERE     (id IN (1,2))

Granted, you can just write the query like this:

  User.where('id IN (?)', [1,2])

which will work. But that seems rather non-intuitive. It seems the postgres adapter should wrap any array with () when generating SQL).

PS. The same results in MYSQL.

You flagged this item as spam.
Andrea Campi October 10th, 2010 @ 10:04 PM
-1

It would seem to me that if you are passing a String with an explicit IN, you know what you are doing with the DB and you should know you need the (). The documentation for e.g. finder_methods has:
```
Person.where(["category IN (?)", categories]).limit(50).all
```
Besides, this works and is IMHO more readable:
```
User.where(:id => [1,2])
```
Ryan Bigg October 11th, 2010 @ 02:59 AM
- Importance changed from “” to “Low”
Automatic cleanup of spam.
Ryan Bigg October 19th, 2010 @ 08:24 AM
Automatic cleanup of spam.
Santiago Pastorino February 2nd, 2011 @ 04:48 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:48 PM
- State changed from “open” to “stale”

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>