#5333 Various test case conditions for the SQLServerAdapter - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5333 ✓committed

Various test case conditions for the SQLServerAdapter

Reported by Ken Collins | August 8th, 2010 @ 04:34 AM

A few test case conditions that would be nice to have in the 3.0 release.

Comments and changes to this ticket

You flagged this item as spam.
Ken Collins August 8th, 2010 @ 04:48 AM
Doh! Forgot to attach the patch.
- sqlserver_testcase_conditions.diff 8.1 KB
You flagged this item as spam.
Ken Collins August 8th, 2010 @ 11:11 PM
I am going to continue to keep coerced test cases in the adapters code, however I do need this change (new patch attached) to the schema.rb so that it loads up correctly. We are using the same precision for atoms_in_universe as the Oracle adapter.
- sqlserver_schema.diff 1.1 KB
You flagged this item as spam.
Ken Collins August 9th, 2010 @ 02:53 AM
Wow, another schema bug found. I found items.name was an :integer vs a :string data type which caused fixtures to blow up when running tests. Updated patch attached.
- sqlserver_schema2.diff 1.3 KB
You flagged this item as spam.
Ken Collins August 10th, 2010 @ 08:57 PM
I just noticed that others reported this issue in #4967 but this ticket has tested patches.
You flagged this item as spam.
Henrik Hodne August 11th, 2010 @ 01:15 AM
- Tag changed from “3.0, activerecord, sqlserver” to “3.0, activerecord, patch, sqlserver”
You flagged this item as spam.
kdgundermann September 1st, 2010 @ 08:50 AM
+1 tested on Windows with SQLServer 2005 / 2008 Necessary, else some Rails tests will fail
Michael Koziarski September 3rd, 2010 @ 03:59 AM
- State changed from “new” to “committed”
- Importance changed from “” to “Low”
The first one doesn't apply any longer, is it still required?

Your later one has been applied to master and 3-0-stable.
You flagged this item as spam.
Ken Collins September 3rd, 2010 @ 04:08 AM
Correct, the first file is no longer needed. We dynamically redefine the test cases needed for the adapter vs cluttering the rails test suite with our stuff. Allows us to cope with out own internal changes and DB versions more easily.

Thanks for this and your commit on 5188!