#5368 weird behavior on expire_page when you are running under namespace - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5368 ✓invalid

weird behavior on expire_page when you are running under namespace

Reported by Daniel Lopes | August 12th, 2010 @ 10:18 PM

[This ticket is not a bug, somebody could close it?]

Today when I'm testing Rails 3.0 I found a behavior that I think is bug.

If you have a blog with an admin and public area like below:

  namespace :admin do
    resources :posts
  end

  resources :posts

And create a sweeper like:


class PostSweeper < ActionController::Caching::Sweeper
  def after_save(resource)
    expire_cache(resource)
  end

  def after_destroy(resource)
    expire_cache(resource)
  end

  def expire_cache(resource)
    expire_page :controller => "posts", :action => "show"
  end
end

If you set this sweeper in Admin::PostsController and do a change in the post from Admin namespace Rails will try to expire:

/developer/app/public/admin/posts/1-rails-3-0-rc.html

And not:

/developer/app/public/posts/1-rails-3-0-rc.html

When I look the code of expire_page I found this:

http://apidock.com/rails/ActionController/Caching/Pages/ClassMethod...

This method will use the URI to set the path for the file which ends with the weird behavior above. Don't you guy think this is a bug?

Comments and changes to this ticket

You flagged this item as spam.
Daniel Lopes August 12th, 2010 @ 10:24 PM
To force Rails to don't use admin in path what I did was:

expire_page :controller => "/posts", :action => "show", :only_path => true

But "/posts" is as strange for a controller name. Don't you think?
You flagged this item as spam.
Andrea Campi October 17th, 2010 @ 02:29 PM
- Tag changed from “rails3.0rc” to “rails3”
-1 I'm not sure why do you think this is a bug; taking the namespace in consideration sounds like the only reasonable behavior to me.
You flagged this item as spam.
Daniel Lopes October 19th, 2010 @ 02:36 PM
Andrea, I didn't said anything about the Admin namespace in the Sweeper. That is the reason why I think this is undesired. What I think is the right thing to expire the admin posts is:

expire_page :controller => 'admin/posts', :action => 'index'

But expire the admin when I want to expire the public controller, for me, is strange/
You flagged this item as spam.
Andrea Campi October 19th, 2010 @ 10:09 PM
The Sweeper itself may not be in the Admin namespace, but you are assigning it to the @Admin::PostsController@; when #expire_page is invoked, it invoked @#url_for@, which will take the controller namespace into consideration to build the cache path.
That sounds consistent to the way #url_for works.
You flagged this item as spam.
Daniel Lopes October 20th, 2010 @ 02:04 PM
Actually I any place I reference the admin namespace in the sweeper, neither in the controllers. The sweeper will expire the Admin controller without I said to do that.
You flagged this item as spam.
Andrea Campi October 20th, 2010 @ 04:27 PM
Your controller is named Admin::PostsController. That's all the namespacing Rails needs to see.

If that's not the case, you need to show more of your controllers, otherwise there's no way I can guess what you mean.
You flagged this item as spam.
Daniel Lopes October 20th, 2010 @ 11:50 PM
I attached an app for the example. In the source folder I have a PostsController and an Admin::PostsController. My admin calls the cache_sweeper method and say to dispatch it in create and update.

My Sweeper observes the Post model and in the right callback it calls:

expire_page :controller => "posts", :action => "show", :only_path => true

But calling just posts in the expire_page and not admin/posts will expire admin/posts. For me it's against of the principle of least surprise. Rails inferrers that I want to expire the admin just because the controller that call cache_sweeper is in Admin namespace even when I say explicitly that the controller is just posts?

For it's a strange.

Take a look in the app attached.
- app.zip 115.3 KB
You flagged this item as spam.
Andrea Campi October 22nd, 2010 @ 03:44 PM
But calling just posts in the expire_page and not admin/posts will expire admin/posts. For me it's against of the principle of least surprise. Rails inferrers that I want to expire the admin just because the controller that call cache_sweeper is in Admin namespace even when I say explicitly that the controller is just posts?

Yes, that's what I was trying to tell you, sorry if I didn't make it clear.

Personally, I don't find it confusing at all, it's exactly how I would expect it to work. For instance, that's how link_to works:
```
link_to 'test', :controller => "posts", :action => "index} # <a href="/admin/posts">test</a>

link_to 'test', :controller => "/posts", :action => "index} # <a href="/posts">test</a>
```
If expire_page and link_to were to build different URLs, now that would be confusing!
You flagged this item as spam.
Daniel Lopes October 22nd, 2010 @ 04:09 PM
Now I got what are you trying to explain. In the context of views is pretty clear when the view that call's link_to (and uses url for behind) will take his own controller as scope for the url.

In the sweepers I don't think it's so clear that's the calling of cache_sweeper in the controller will be responsible for set the scope for the url_for. But I got what you tried to explain and looking for the point of view of a link_to you are correct.

I will close this ticket.
Rohit Arondekar January 27th, 2011 @ 06:36 AM
- State changed from “new” to “invalid”
- Importance changed from “” to “Low”