#5372 Test to exercise Callbacks#reset_callbacks for descendants - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5372 ✓stale

Test to exercise Callbacks#reset_callbacks for descendants

Reported by Marcelo Giorgi | August 13th, 2010 @ 03:12 AM

Here I attach a simple patch, that exercise the cleaning of the callbacks for the descendants classes of the one that invoked ActiveSupport#reset_callbacks.

Let me know if it is ok

Comments and changes to this ticket

You flagged this item as spam.
Marcelo Giorgi August 13th, 2010 @ 03:16 AM
Here is the patch
- test-to-exercises-reset-callbacks-for-descendants.diff 1 KB
You flagged this item as spam.
Marcelo Giorgi August 13th, 2010 @ 03:17 AM
- Tag set to “patch”
Rohit Arondekar October 15th, 2010 @ 10:55 AM
- State changed from “new” to “open”
- Assigned user set to “José Valim”
- Importance changed from “” to “Low”
Still applies cleanly and the test passes.

Only one doubt — should this test have it's own separate class?
You flagged this item as spam.
Marcelo Giorgi October 15th, 2010 @ 07:06 PM
Yeah, you're right perhaps it's better to encapsulate this test into its own class.

Here I attach a patch implementing that suggestion.
- test-within-own-class-to-exercise-reset-callbacks-for-descendants.diff 1.1 KB
Rohit Arondekar October 26th, 2010 @ 10:06 AM
What I had originally meant was instead of modifying CleanPerson class, writing a completely new one for this test only. To be honest though, I don't think either what I suggested or what you've done is really needed. I think it's good to go.
Jeff Kreeftmeijer November 1st, 2010 @ 05:05 PM
- Tag cleared.
Automatic cleanup of spam.
Santiago Pastorino February 2nd, 2011 @ 04:20 PM
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:20 PM
- State changed from “open” to “stale”