Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Test to exercise Callbacks#reset_callbacks for descendants

#5372

Here I attach a simple patch, that exercise the cleaning of the callbacks for the descendants classes of the one that invoked ActiveSupport#reset_callbacks.

Let me know if it is ok

Reported by Marcelo Giorgi · August 13th, 2010 @ 03:12 AM

State: stale
Milestone: none
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Marcelo Giorgi
  2. Marcelo Giorgi
  3. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to open
    • Assigned user set to José Valim
    • Importance changed from to Low

    Still applies cleanly and the test passes.

    Only one doubt — should this test have it's own separate class?

    October 15th, 2010 @ 10:55 AM

  4. Marcelo Giorgi
    Marcelo Giorgi

    Yeah, you're right perhaps it's better to encapsulate this test into its own class.

    Here I attach a patch implementing that suggestion.

    October 15th, 2010 @ 07:06 PM

  5. Rohit Arondekar
    Rohit Arondekar

    What I had originally meant was instead of modifying CleanPerson class, writing a completely new one for this test only. To be honest though, I don't think either what I suggested or what you've done is really needed. I think it's good to go.

    October 26th, 2010 @ 10:06 AM

  6. Jeff Kreeftmeijer
    Jeff Kreeftmeijer
    • Tag cleared.

    Automatic cleanup of spam.

    November 1st, 2010 @ 05:05 PM

  7. Santiago Pastorino
    Santiago Pastorino

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:20 PM

  8. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:20 PM