This project is archived and is in readonly mode.
Test to exercise Callbacks#reset_callbacks for descendants
-
Marcelo Giorgi
Here is the patch
-
Marcelo Giorgi
- Tag set to patch
-
Rohit Arondekar
- State changed from new to open
- Assigned user set to José Valim
- Importance changed from to Low
Still applies cleanly and the test passes.
Only one doubt — should this test have it's own separate class?
-
Marcelo Giorgi
Yeah, you're right perhaps it's better to encapsulate this test into its own class.
Here I attach a patch implementing that suggestion.
-
Rohit Arondekar
What I had originally meant was instead of modifying
CleanPersonclass, writing a completely new one for this test only. To be honest though, I don't think either what I suggested or what you've done is really needed. I think it's good to go. -
Santiago Pastorino
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
