Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Marcelo Giorgi

Marcelo Giorgi

Ruby/JS Developer · Not a member

Marcelo Giorgi's latest activity

Friday, October 22 2010
5336 AssociationCollection#include? ignoring build associated objects (not working... was updated in Ruby on Rails
Friday, October 15 2010
5372 Test to exercise Callbacks#reset_callbacks for descendants was updated in Ruby on Rails
  • Marcelo Giorgi
    Marcelo Giorgi commented at 7:06 PM

    Yeah, you're right perhaps it's better to encapsulate this test into its own class.

    Here I attach a patch implementing that suggestion.
Sunday, October 03 2010
5648 after_filter not halted was updated in Ruby on Rails
  • Marcelo Giorgi
    Marcelo Giorgi commented at 3:34 PM

    Hi Neeraj and Jose,

    Neeraj, I run your code with rails edge and got the following output for this url http://localhost:3000/users:

    before >>>before >>>before >>...
  • Marcelo Giorgi
    • Assigned user set to Santiago Pastorino
    • Tag changed from rails 3.0.0, actionpack, after_filter, before_filter, callbacks, chain to rails 3.0.0, actionpack, after_filter, before_filter, callbacks, chain, patch
    by Marcelo Giorgi at 4:51 AM

    Hi Bertg,

    I agree with you, I would expect Rails 3 to inherit the behavior of Rails 2.3.x filters.

    For that, I've wrote tests and patch to make it work as you s...
Friday, October 01 2010
5721 count with group by discards :distinct option was updated in Ruby on Rails
  • Marcelo Giorgi
    • Assigned user set to Santiago Pastorino
    • Tag set to activerecord calculation, patched
    by Marcelo Giorgi at 12:40 PM

    Hi,

    I implemented a test and patch for this.

    This applies cleanly to master now.
Thursday, September 30 2010
5336 AssociationCollection#include? ignoring build associated objects (not working... was updated in Ruby on Rails
  • Marcelo Giorgi
    Marcelo Giorgi commented at 7:36 PM

    Here it is, I've just tested and applies cleanly on master.

    Thank you very much!
Friday, September 24 2010
5626 ActiveRecord generates invalid SQL when eager loading a hmt association with ... was updated in Ruby on Rails
  • Marcelo Giorgi
    • Assigned user changed from Aaron Patterson to Santiago Pastorino
    by Marcelo Giorgi at 2:02 AM

    Hi Ryan,

    I think the bug that you found is a different problem, in fact I think it is a more general issue of Rails. As you mentioned it is arguable that the de...
Thursday, September 23 2010
5688 <Model>.offset(x).limit(x) unknown offset method exception was updated in Ruby on Rails
  • Marcelo Giorgi
    • Tag set to activerecord, patched, scope
    by Marcelo Giorgi at 11:22 PM

    Hi vhochstein,

    Yeah, I totally agree, it should behave in the same way as #limit.

    Here I provide a couple of tests and a patch for this case based on your sugge...
Thursday, September 16 2010
5626 ActiveRecord generates invalid SQL when eager loading a hmt association with ... was updated in Ruby on Rails
  • Marcelo Giorgi
    • Assigned user set to Santiago Pastorino
    • Tag changed from 2.3.9, activerecord, eager_loading, has_many_through to 2.3.9, activerecord, eager_loading, has_many_through, patched
    by Marcelo Giorgi at 2:58 AM
  • Marcelo Giorgi
    Marcelo Giorgi commented at 2:57 AM

    Hi Ryan,

    I've just implement a patch for this.

    My work was based on your test, so I've added 2 patch files, 1 with your test (where you are the author), and the...