#5397 rake test:uncommitted raises undefined method map on String - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5397 open

rake test:uncommitted raises undefined method map on String

Reported by Sunny | August 17th, 2010 @ 11:43 PM

Running the task test:uncommited raises an undefined method 'map' for String, using git.

$ rake --trace test:uncommitted
[...]
rake aborted!
undefined method `map' for #<String:0x8f3c728>
~/.gems/railties-3.0.0.beta4/lib/rails/test_unit/testing.rake:77:in `file_list'
[...]

My environment:

$ ruby -v
ruby 1.9.2dev (2010-07-30 revision 28788) [i686-linux]
$ rails -v
Rails 3.0.0.beta4

Comments and changes to this ticket

You flagged this item as spam.
Sunny August 17th, 2010 @ 11:44 PM
- Tag changed from “git” to “git, rake, test”
Patch that fixes this: http://github.com/sunny/rails/commit/22a13782b \o/
You flagged this item as spam.
Sunny August 18th, 2010 @ 12:05 AM
- Tag changed from “git, rake, test” to “git, patch, rake, test”
Attaching diff rather than github fork.
- rake-test-uncommited-map-string-error.diff 1.2 KB
You flagged this item as spam.
Sunny August 18th, 2010 @ 12:15 AM
- State changed from “new” to “resolved”
Added [#5397 state:resolved] to commit message.
- rake-test-uncommited-map-string-error.diff 1.3 KB
Santiago Pastorino August 18th, 2010 @ 04:37 PM
- State changed from “resolved” to “open”
- Importance changed from “” to “Low”
You flagged this item as spam.
Sunny January 17th, 2011 @ 10:00 PM
- Tag changed from “git, patch, rake, test” to “git, patch, rake, ruby1.9, test”
This is a Ruby 1.9 issue. Strings don't come with .map() anymore so this task always fails.
Josh Kalderimis February 13th, 2011 @ 01:09 PM
- Tag changed from “git, patch, rake, ruby1.9, test” to “rake, ruby1.9”
- Assigned user set to “Josh Kalderimis”
Hi Sunny,

I have spoken to José about this issue, and although your patch does fix it, the bigger issue at hand is that this code (rake task) isn't tested at all.

Ideally the code within def files should be extracted into its own class which is tested and then used in this rake task.

If you are still interested in working on this patch please let me know.

Thanks

Josh
You flagged this item as spam.
Sunny February 16th, 2011 @ 01:19 PM
I'm interested in working on this patch but I'm not very familiar with the Rails codebase. It might take long.

As for testing it, the tests would depend on svn and git. Is that ok for Rails?
Josh Kalderimis February 16th, 2011 @ 02:01 PM
Hi Sunny,

This is a good patch to start off with.

And the tests won't need to depend on svn or git as we can stub out those parts.

Fork rails, create a new branch for what you are doing, and start making changes, if you have any questions do not hesitate to ask, you can also find me on irc in #rails-contrib.

I will leave the ticket assigned to me so I can monitor its progress.

Thanks

Josh
You flagged this item as spam.
Sunny March 7th, 2011 @ 01:29 PM
Thanks Josh! Started making a few changes in a testuncommited branch. Not sure I'm placing things where they should be and feeling somewhat stuck. Guess I need to crawl through the whole Rails test suite to find similar tests.
You flagged this item as spam.
bingbing March 26th, 2011 @ 02:14 AM
louis vuitton watches