This project is archived and is in readonly mode.
Cannot rescue from ActionController::UnknownHttpMethod
Reported by Bill Kirtley | August 19th, 2010 @ 09:35 PM
Requests that come in with unknown HTTP verbs ring alarms and I'd like to send them away with a 405 method_not_allowed for their trouble.
The approach I would think would work:
rescue_from ActionController::UnknownHttpMethod, :with => proc { head :method_not_allowed }
... doesn't work, as an exception is raised trying to interpret the request to log it. Alarms ring, client sees 500 instead of 405.
The fix seems to be reasonably well contained in 2-3-stable, but gets really fuzzy in the stack of middlewares and gems in 3-0-stable.
In 3-0-stable the exception is raised in the ActionDispatch::Request#request_method, which is documented to "return the HTTP method that the application should see", with no mention of restricting to "valid" methods, or raising exceptions. So it seems reasonable to just remove the check there.
But somebody ought to be checking, maybe in the dispatcher? Have a separate check for valid methods there?
Comments and changes to this ticket
-
Santiago Pastorino February 2nd, 2011 @ 04:59 PM
- State changed from “new” to “open”
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:59 PM
- State changed from “open” to “stale”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Andrea Campi
Bill Kirtley