Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Cannot rescue from ActionController::UnknownHttpMethod

#5414

Requests that come in with unknown HTTP verbs ring alarms and I'd like to send them away with a 405 method_not_allowed for their trouble.

The approach I would think would work:

rescue_from ActionController::UnknownHttpMethod, :with => proc { head :method_not_allowed }

... doesn't work, as an exception is raised trying to interpret the request to log it. Alarms ring, client sees 500 instead of 405.

The fix seems to be reasonably well contained in 2-3-stable, but gets really fuzzy in the stack of middlewares and gems in 3-0-stable.

In 3-0-stable the exception is raised in the ActionDispatch::Request#request_method, which is documented to "return the HTTP method that the application should see", with no mention of restricting to "valid" methods, or raising exceptions. So it seems reasonable to just remove the check there.

But somebody ought to be checking, maybe in the dispatcher? Have a separate check for valid methods there?

Reported by Bill Kirtley · August 19th, 2010 @ 09:35 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:59 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:59 PM