This project is archived and is in readonly mode.
ActiveRecord::record_timestamps broken in RC2 (regression from RC1)
-
Wincent Colaiuta
- Assigned user set to José Valim
Output from
git bisectreveals that this commit is the culprit:30ea923040ded944209c98383389b6c9aafe806a is the first bad commit commit 30ea923040ded944209c98383389b6c9aafe806a Author: José Valim <jose.valim@gmail.com> Date: Thu Aug 12 12:04:16 2010 -0300 Make update_attribute behave as in Rails 2.3 and document the behavior intrinsic to its implementation. :040000 040000 22165ee5875272a3e985c8fec168483b2c885a89 2ec79fa40b23c189cad633ae076204835fda4e83 M activerecord -
José Valim
- Milestone cleared.
- State changed from new to open
- Importance changed from to High
Could you please to attach a failing test case in ActiveRecord test suite? And I will fix it ASAP.
-
José Valim
The fix is simple:
http://github.com/rails/rails/commit/30ea923040ded944209c98383389b6...
We are missing a parenthesis there. Just waiting for the test case to fix it (feel free to include the fix in your patch as well!).
-
Wincent Colaiuta
Here's a test case, but I can't actually run it yet because Bundler is giving me hell. Hopefully it's right. In the meantime I'll continue to fight with Bundler.
-
Repository
- State changed from open to resolved
(from [6ef60bd9ffff44187b3016d00923835a609293bf]) Ensure timestamps are not generated when explicitly set to false [#5440 ActiveRecord::record_timestamps broken in RC2 (regression from RC1) state:resolved] http://github.com/rails/rails/commit/6ef60bd9ffff44187b3016d0092383...
-
Repository
(from [c857bd23c0ee6f0368a75fe608faed9bbdf1a415]) Ensure timestamps are not generated when explicitly set to false [#5440 ActiveRecord::record_timestamps broken in RC2 (regression from RC1) state:resolved] http://github.com/rails/rails/commit/c857bd23c0ee6f0368a75fe608faed...
-
Wincent Colaiuta
Thanks for the quick fix.
