This project is archived and is in readonly mode.

#5454 ✓stale
rap-kasta

Use validates_associated with :reverse_of cause infinite loop

Reported by rap-kasta | August 25th, 2010 @ 02:54 PM

class Task < ActiveRecord::Base
  has_many :task_items, :inverse_of=>:task, :dependent => :destroy
  accepts_nested_attributes_for :task_items
end

class TaskItem < ActiveRecord::Base
  belongs_to :task, :inverse_of=> :task_items
  validates_presence_of :task
  validates_associated :task
end
task=Task.new :task_items_attributes=>{...}
task.valid? #infinite loop here

If we remove @@@validates_associated :task@@@ all will work properly.

Comments and changes to this ticket

  • Neeraj Singh

    Neeraj Singh September 7th, 2010 @ 05:33 PM

    • Importance changed from “” to “Low”

    I am not able to reproduce it with rails edge. This is what I did

        # nested attributes
        create_table :surveys, :force => true do |t|
          t.string :name
        end
        create_table :questions, :force => true do |t|
          t.text :name
          t.integer :survey_id
        end
    
    
    class Survey < ActiveRecord::Base
    
      has_many :questions, :dependent => :destroy, :inverse_of => :survey
    
      accepts_nested_attributes_for :questions
    
      validates_presence_of :name
    
      def self.lab
      end
    
    end
    
    
    
    
    class Question < ActiveRecord::Base
      belongs_to :survey, :inverse_of => :question
      validates_presence_of :question
      validates_associated :question
    
      def self.lab
      end
    
    end
    
    
    ree-1.8.7-2010.01 > survey = Survey.new :questions_attributes => {}
     => #<Survey id: nil, name: nil> 
    ree-1.8.7-2010.01 > survey.valid?
     => false
    
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:32 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:32 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages