Generators spew stack traces when no type is provided for attributes

Confirmed.

~/bugmash/devapp९ script/rails generate model MyModel name
/home/rohit/projects/rails/activesupport/lib/active_support/whiny_nil.rb:48:in `method_missing': undefined method `to_sym' for nil:NilClass (NoMethodError)
    from /home/rohit/projects/rails/railties/lib/rails/generators/generated_attribute.rb:9:in `initialize'
    from /home/rohit/projects/rails/railties/lib/rails/generators/named_base.rb:92:in `new'
    from /home/rohit/projects/rails/railties/lib/rails/generators/named_base.rb:92:in `block in parse_attributes!'
    from /home/rohit/projects/rails/railties/lib/rails/generators/named_base.rb:90:in `map'
    from /home/rohit/projects/rails/railties/lib/rails/generators/named_base.rb:90:in `parse_attributes!'
    from /home/rohit/projects/rails/railties/lib/rails/generators/named_base.rb:14:in `initialize'
    from /home/rohit/.rvm/gems/ruby-1.9.2-p0@3-dev/gems/thor-0.14.0/lib/thor/group.rb:226:in `new'
    from /home/rohit/.rvm/gems/ruby-1.9.2-p0@3-dev/gems/thor-0.14.0/lib/thor/group.rb:226:in `dispatch'
    from /home/rohit/.rvm/gems/ruby-1.9.2-p0@3-dev/gems/thor-0.14.0/lib/thor/base.rb:389:in `start'
    from /home/rohit/projects/rails/railties/lib/rails/generators.rb:163:in `invoke'
    from /home/rohit/projects/rails/railties/lib/rails/commands/generate.rb:10:in `<top (required)>'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:239:in `require'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:239:in `block in require'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:225:in `block in load_dependency'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:591:in `new_constants_in'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:225:in `load_dependency'
    from /home/rohit/projects/rails/activesupport/lib/active_support/dependencies.rb:239:in `require'
    from /home/rohit/projects/rails/railties/lib/rails/commands.rb:17:in `<top (required)>'
    from script/rails:6:in `require'
    from script/rails:6:in `<main>'

Would certainly be nice if there was an error message stating that the field needs a type.

Would you be interested in making a patch? This will be helpful: Contributor Guide

How about this?

~/bugmash/error_app९ script/rails g model FooBar foo
Missing type for attribute 'foo'.
Example: 'foo:string' where string is the type.

~/bugmash/error_app९ script/rails g model FooBar title:string count:integer body
Missing type for attribute 'body'.
Example: 'body:string' where string is the type.

Since LH ate my patch, here is a gist: https://gist.github.com/4b0028201b5fe613baba

(from [d2fc5e2f6575b4111f2f87ebca7f021e681d4df9]) Output a friendly message when no type given for GeneratedAttribute [#5461 Generators spew stack traces when no type is provided for attributes state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d2fc5e2f6575b4111f2f87ebca7f02...

(from [5c067772933602b1783d73df70d89ac259bdc887]) Failing test for GeneratedAttribute [#5461 Generators spew stack traces when no type is provided for attributes state:open]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/5c067772933602b1783d73df70d89a...

(from [6a60387dce327b038ab16e1950d723e7b02a063d]) Add two integration tests for GeneratedAttribute missing type error. [#5461 Generators spew stack traces when no type is provided for attributes state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/6a60387dce327b038ab16e1950d723...