default_scope doesn't work at a late point

#4427 Strange behaviour in exception display looks like a different problem.

I guess add a line in default_scope to clear Thread.current[key] will resolve this problem?

Do you mean reset_scoped_methods in default_scope will cause the following run more times?

Thread.current[key] = Thread.current[key].presence || self.default_scoping.dup

default_scope only runs when model classes loading, so I think this is not a big problem?

Also correctness should be the first goal? ;)

One more doubt, this one is more serious though — the test passes without the fix. I commented out the reset_scoped_methods and ran the suite:

(ruby-1.9.2@3-dev)(~/projects/rails/activerecord)९ rake test_sqlite3 TEST=test/cases/base_test.rb 2>/dev/null 
(in /home/rohit/projects/rails/activerecord)
Using native SQLite3
Loaded suite /home/rohit/.rvm/gems/ruby-1.9.2-p0@3-dev/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
............................................................................................................................
Finished in 1.197417 seconds.

124 tests, 305 assertions, 0 failures, 0 errors, 0 skips

Test run options: --seed 15670

Shouldn't the test fail without the fix?

The real problem is default_scope doesn't merge where clauses correctly. Sorry for my inaccurate description in original ticket.

The new test I added is in relation_scoping_test.rb, try with TEST=test/cases/relation_scoping_test.rb?

(from [21beedf1ff925613fb1ca9b3cf44d10526b64a2e]) default scope merge where clauses [#5488 default_scope doesn't work at a late point state:resolved] http://github.com/rails/rails/commit/21beedf1ff925613fb1ca9b3cf44d1...