Rails Ruby on Rails

Comments and changes to this ticket

• 

  José Valim September 1st, 2010 @ 11:29 PM

  • Importance changed from “” to “Low”

  Patch please!

• 

  Neeraj Singh September 2nd, 2010 @ 04:48 AM

  • State changed from “new” to “open”

  Stephen : nice catch.

        # Return true if the cache contains an entry for the given key.
        #
        # Options are passed to the underlying cache implementation.
        def exist?(name, options = nil)
          options = merged_options(options)
          instrument(:exist?, name) do |payload|
            entry = read_entry(namespaced_key(name, options), options)
            puts entry.inspect
            if entry && !entry.expired?
              true
            else
              false
            end
          end
        end
  

  Above method which is declared in AS cache.rb does get hold of the entire cached payload.

  However there is one thing to notice. This is an API for these storage types.

  #   config.action_controller.cache_store = :memory_store
  #   config.action_controller.cache_store = :file_store, "/path/to/cache/directory"
  #   config.action_controller.cache_store = :drb_store, "druby://localhost:9192"
  #   config.action_controller.cache_store = :mem_cache_store, "localhost"
  #   config.action_controller.cache_store = :mem_cache_store, Memcached::Rails.new("localhost:11211")
  #   config.action_controller.cache_store = MyOwnStore.new("parameter")
  

  If you change the code in cache.rb to return the payload instead of true if there is content and use that value going forward then there is a possibility that a custom implementation of cache storage might be overriding 'def exist?' and might be returning true or false. In that case be using 'true' as the payload.

  I guess this fix is very much needed. However we should publish this change in API so that custom impelementation of cache is not caught off guard.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:49 PM

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:49 PM

  • State changed from “open” to “stale”