This project is archived and is in readonly mode.
Fix misleading advice to add 'memcache' to Gemfile
Commit 57144388f removed the hard-coded dependency on the memcache-client gem, and added a warning advising people to install it if needed. The problem is, however, that if people follow the advice literally and install the 'memcache' gem, they will wind up with a completely different thing, which is not API compatible with the memcache-client gem and which Rails can't work with.
So, be explicit and tell users to install the 'memcache-client' gem.
Patches against master and 3-0-stable attached.
-
Jeff Kreeftmeijer- Tag set to memcache, patch, warning
- Importance changed from to Low
This message never told you to put "memcache" in your Gemfile. It said you don't have a thing called "memcache" installed. I understand how this can be misleading, though.
+1
-
Wincent Colaiuta
No, it did tell you to put "memcache" in your Gemfile; read what it says:
You don't have memcache installed in your application. Please add it to your Gemfile
Please at "it" to your Gemfile, where "it" here can only refer to "memcache".
-
Jeff Kreeftmeijer
Again, I know it was misleading, but it told you to require memcache (the library), not to add "memcache" (the string) to your Gemfile. I completely agree with your patch, though. :)
-
Jeff Kreeftmeijer
- Title changed from [PATCH] Fix misleading advice to add 'memcache' to Gemfile to Fix misleading advice to add 'memcache' to Gemfile
-
Wincent Colaiuta
it told you to require memcache (the library), not to add "memcache" (the string) to your Gemfile.
So, you're saying that "Please add it to your Gemfile" means "Require it". Rubbish.
-
Repository
- State changed from new to committed
(from [f659a1576fc4a447bbfbd866c7244d8d790a3d9c]) Fix misleading advice to add 'memcache' to Gemfile
[#5539 Fix misleading advice to add 'memcache' to Gemfile state:committed]
Commit 57144388f removed the hard-coded dependency on the memcache-client
gem, and added this warning advising people to install it if needed. The
problem is, however, that if people follow the advice literally and install
the 'memcache' gem, they will wind up with a completely different thing,
which is not API compatible with the memcache-client gem and which Rails
can't work with.So, be explicit and tell users to install the 'memcache-client' gem.
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/f659a1576fc4a447bbfbd866c7244d... -
Repository
(from [3a6acb616235349f829236ec04a182d27fe2d397]) Fix misleading advice to add 'memcache' to Gemfile
[#5539 Fix misleading advice to add 'memcache' to Gemfile state:committed]
Commit 57144388f removed the hard-coded dependency on the memcache-client
gem, and added this warning advising people to install it if needed. The
problem is, however, that if people follow the advice literally and install
the 'memcache' gem, they will wind up with a completely different thing,
which is not API compatible with the memcache-client gem and which Rails
can't work with.So, be explicit and tell users to install the 'memcache-client' gem.
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/3a6acb616235349f829236ec04a182... -
